Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ubsan errors #5037

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Fix ubsan errors #5037

merged 3 commits into from
Apr 17, 2019

Conversation

vitlibar
Copy link
Member

@vitlibar vitlibar commented Apr 17, 2019 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Category (leave one):

  • Build/Testing/Packaging Improvement

Fixed several ubsan errors:

  • fix ubsan error "outside the range of representable values" in convertFieldToType.cpp;
  • fix ubsan error "load of misaligned address" in contrib/libmetrohash/src/platform.h;
  • disable ubsan error "outside the range of representable values" in bitSwapLastTwo.cpp.

@vitlibar vitlibar requested a review from proller April 17, 2019 16:28
@vitlibar vitlibar removed the request for review from proller April 17, 2019 16:32
@alexey-milovidov alexey-milovidov self-assigned this Apr 17, 2019
@vitlibar vitlibar merged commit 345ae9a into ClickHouse:master Apr 17, 2019
@vitlibar vitlibar deleted the fix-ubsan-errors branch April 17, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@proller proller

@alexey-milovidov alexey-milovidov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitlibar @alexey-milovidov @proller @abyss7