Fix settings.max_partitions_per_insert_block type #5028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `max_partitions_per_insert_block` field is of `size_t` type, rather than `Boolean`
mohammad7t
added a commit
to mohammad7t/clickhouse-driver
that referenced
this pull request
Apr 17, 2019
The `max_partitions_per_insert_block` is defined in: https://github.com/yandex/ClickHouse/blob/f566182582c70986be19777b3583c803607928ad/dbms/src/Core/Settings.h#L315 Regarding the data type, I have submitted the pull request ClickHouse/ClickHouse#5028 because it is used in other places of code as `size_t`, rather than `boolean`.
alexey-milovidov
added
pr-bugfix
|
Also cherry-picked to #4884 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Short description (up to few sentences):
The
max_partitions_per_insert_blockfield is ofsize_ttype, rather thanBoolean