Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the correct timestamp for the right-hand table of the ASOF join #4867

Merged
merged 6 commits into from
Apr 1, 2019

Conversation

Gladdy
Copy link
Contributor

@Gladdy Gladdy commented Mar 31, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog.
Return the correct timestamp for the right-hand table of the ASOF join

Category

  • Bug Fix

Short description (up to few sentences):
Previously it would copy the timestamp from the left hand side, whereas the right hand side might have had a different timestamp. This patch fixes that.

@Gladdy Gladdy changed the title Martijn asof working bt Return the correct timestamp for the right-hand table of the ASOF join Mar 31, 2019
dbms/src/Interpreters/Join.cpp Outdated Show resolved Hide resolved
dbms/src/Interpreters/Join.h Outdated Show resolved Hide resolved
dbms/src/Interpreters/Join.cpp Outdated Show resolved Hide resolved
dbms/src/Interpreters/Join.cpp Outdated Show resolved Hide resolved
dbms/src/Interpreters/Join.cpp Outdated Show resolved Hide resolved
@Gladdy
Copy link
Contributor Author

Gladdy commented Apr 1, 2019

Thanks, will patch those up. Do you have any better way of checking the code style other than the included scripts in utils/check-style that would actually catch these issues (they, and by extension your CI system does not report these style issues)? Also, when I actually run the clang-format tool with the included .clang-format file it catches many other things too hence would mess up history so I'm a bit wary of doing that and prefer to stick with the pre-written format scripts that already include/exclude whatever stuff clang-format does that you care about.

@4ertus2
Copy link
Contributor

4ertus2 commented Apr 1, 2019

Thanks, will patch those up. Do you have any better way of checking the code style other than the included scripts in utils/check-style that would actually catch these issues (they, and by extension your CI system does not report these style issues)?

We have style checker but it is not ideal yet. Maybe one day it could catch all the style mistakes.

@4ertus2 4ertus2 merged commit b6b9be7 into ClickHouse:master Apr 1, 2019
@abyss7 abyss7 added the pr-bugfix Pull request with bugfix, not backported by default label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants