Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test failures when running clickhouse-server on different host #4713

Merged

Conversation

Enmk
Copy link
Contributor

@Enmk Enmk commented Mar 16, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Category (leave one):

  • Build/Testing/Packaging Improvement

Short description (up to few sentences):
Further improvement of the docker-based test machinery
...

Detailed description (optional):

test_runner.sh

  • Multi-stage builds for test-runner and server to allow putting packages directory anywhere
  • Option to skip re-building docker images (useful for testing along with mounting local test-files to the test-runner container)

Fixed Test:

  • Tests that were connecting to localhost rather than to CLICKHOUSE_HOST

    • 00354_host_command_line_option
    • 00646_url_engine
  • Tests that were not ensuring that certain option is set:

    • 00838_unique_index
    • 00838_minmax_index
  • Tests that were trying to write extra data to the readonly directory rather than to CLICKHOUSE_TMP:

    • 00634_performance_introspection_and_logging
    • 00634_logging_shard

Clickhouse-test

  • Fixed clickhouse-test error reporting when diff contains non-ascii characters
  • more detailed error reporting for internal errors
    ...

@alexey-milovidov
Copy link
Member

Need to fix up "00646_url_engine" test.

@alexey-milovidov
Copy link
Member

Still waiting for test fix.

Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Enmk Enmk force-pushed the test_runner_for_stateless_tests branch from c29de7f to 33336e2 Compare March 30, 2019 12:33
Fixed test in docker: writing to read-only filesystem
Multi-stage builds for test-runner and server to allow putting packages directory anywhere
Fixed more tests
@Enmk Enmk force-pushed the test_runner_for_stateless_tests branch from 33336e2 to 9b5950f Compare March 30, 2019 12:39
@Enmk
Copy link
Contributor Author

Enmk commented Mar 30, 2019

.

Sorry for delay, it should be fixed now.

@alexey-milovidov alexey-milovidov merged commit c94b59a into ClickHouse:master Apr 4, 2019
@abyss7 abyss7 added the pr-build Pull request with build/testing/packaging improvement label Apr 8, 2019
@Enmk Enmk deleted the test_runner_for_stateless_tests branch December 8, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants