Fix a race condition during concurrent ALTER COLUMN queries #4592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztlpn
force-pushed
the
fix-concurrent-alters2
branch
4 times, most recently
from
c89c30a to
9de59c8
Compare
ztlpn
force-pushed
the
fix-concurrent-alters2
branch
from
9de59c8 to
09d0ae5
Compare
ztlpn
force-pushed
the
fix-concurrent-alters2
branch
from
09d0ae5 to
f7217d9
Compare
ztlpn
changed the title
| */ | ||
| mutable RWLock data_lock = RWLockImpl::create(); | ||
| /// It is taken for share for the entire INSERT query and the entire merge of the parts (for MergeTree). | ||
| /// ALTER queries acquire an exclusive lock to ensure |
There was a problem hiding this comment.
... that no new data appear?
There was a problem hiding this comment.
oops :) I will add the missing part of the comment.
abyss7
pushed a commit
to abyss7/ClickHouse
that referenced
this pull request
Apr 12, 2019
Fix a race condition during concurrent ALTER COLUMN queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Fix a race condition during concurrent ALTER COLUMN queries that could lead to a server crash (fixes issue #3421).