Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact storage of the part header in ZooKeeper #3960

Merged
merged 8 commits into from
Jan 17, 2019

Conversation

ztlpn
Copy link
Contributor

@ztlpn ztlpn commented Dec 28, 2018

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Improvement

Short description (up to few sentences):

Add a MergeTree setting use_minimalistic_part_header_in_zookeeper. If enabled, Replicated tables will store compact part metadata in a single part znode. This can dramatically reduce ZooKeeper snapshot size (especially if the tables have a lot of columns). Note that after enabling this setting you will not be able to downgrade to a version that doesn't support it.

@ztlpn ztlpn force-pushed the zk-columns-compact-storage branch from 9c7265e to 585190b Compare December 29, 2018 13:05
@ztlpn ztlpn force-pushed the zk-columns-compact-storage branch from 585190b to ca91223 Compare December 29, 2018 14:24
@alexey-milovidov
Copy link
Member

Build in Jenkins: Directory renamed before its status could be extracted - unrelated failure.

Alexey Zatelepin added 2 commits January 16, 2019 17:45
Conflicts:
	dbms/src/Storages/StorageReplicatedMergeTree.cpp
@ztlpn
Copy link
Contributor Author

ztlpn commented Jan 17, 2019

UBsan failure is an unrelated bug in the bitTest function:

$ ./clickhouse local -q 'SELECT bitTest(-607446, -1687822.6)'
../dbms/src/Functions/bitTest.cpp:15:62: runtime error: shift exponent -1687822 is negative

@alexey-milovidov alexey-milovidov merged commit 0ec1fde into master Jan 17, 2019
alexey-milovidov added a commit that referenced this pull request Jan 17, 2019
alexey-milovidov added a commit that referenced this pull request Jan 20, 2019
alexey-milovidov added a commit that referenced this pull request Jan 20, 2019
@blinkov
Copy link
Contributor

blinkov commented Jan 23, 2019

@liuyimin-bytedance @chenxing-xc maybe this feature will be relevant for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants