-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact storage of the part header in ZooKeeper #3960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c7265e
to
585190b
Compare
Conflicts: dbms/src/Common/ErrorCodes.cpp
585190b
to
ca91223
Compare
Build in Jenkins: |
Conflicts: dbms/src/Storages/StorageReplicatedMergeTree.cpp
UBsan failure is an unrelated bug in the
|
alexey-milovidov
approved these changes
Jan 17, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 17, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 20, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 20, 2019
@liuyimin-bytedance @chenxing-xc maybe this feature will be relevant for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Add a MergeTree setting
use_minimalistic_part_header_in_zookeeper
. If enabled, Replicated tables will store compact part metadata in a single part znode. This can dramatically reduce ZooKeeper snapshot size (especially if the tables have a lot of columns). Note that after enabling this setting you will not be able to downgrade to a version that doesn't support it.