-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance introspection #2482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ICKHOUSE-2910] Fixed several test to be compatible with --server_logs_level=warning.
9406c03
to
d5e3787
Compare
/// 0 - wasn't checked | ||
/// 1 - checked, has no permissions | ||
/// 2 - checked, has permissions | ||
static std::atomic<int> premissions_check_status{0}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do check inside constructor of function-static variable and it will be thread safe automatically.
premissions_check_status.store(status, std::memory_order_relaxed); | ||
} | ||
|
||
return status == 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible race condition.
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
…ecause multiple records are generated for each query for query_thread_log. The maximum size of system log queue will be few hundred MBs #2482
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 22, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 24, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 24, 2018
Moved "setcap" from init script to postinst #2482
alexey-milovidov
added a commit
that referenced
this pull request
Aug 30, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 30, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 30, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 31, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 31, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 31, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Sep 6, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Sep 7, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Sep 8, 2018
Fixed usage of query scope in TCPHandler #2482
system.query_log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en