Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance introspection #2482

Merged
merged 57 commits into from
Aug 19, 2018
Merged

Performance introspection #2482

merged 57 commits into from
Aug 19, 2018

Conversation

ludv1x
Copy link
Contributor

@ludv1x ludv1x commented Jun 7, 2018

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@ludv1x ludv1x changed the title [WIP] Perfomance introspection [WIP] Performance introspection Jun 7, 2018
@ludv1x ludv1x force-pushed the CLICKHOUSE-2910 branch 2 times, most recently from 9406c03 to d5e3787 Compare June 13, 2018 19:09
@ludv1x ludv1x force-pushed the CLICKHOUSE-2910 branch from d5e3787 to 4cd230f Compare June 14, 2018 13:10
/// 0 - wasn't checked
/// 1 - checked, has no permissions
/// 2 - checked, has permissions
static std::atomic<int> premissions_check_status{0};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do check inside constructor of function-static variable and it will be thread safe automatically.

premissions_check_status.store(status, std::memory_order_relaxed);
}

return status == 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible race condition.

alexey-milovidov added a commit that referenced this pull request Aug 22, 2018
alexey-milovidov added a commit that referenced this pull request Aug 22, 2018
alexey-milovidov added a commit that referenced this pull request Aug 22, 2018
alexey-milovidov added a commit that referenced this pull request Aug 22, 2018
alexey-milovidov added a commit that referenced this pull request Aug 22, 2018
alexey-milovidov added a commit that referenced this pull request Aug 22, 2018
…ecause multiple records are generated for each query for query_thread_log. The maximum size of system log queue will be few hundred MBs #2482
alexey-milovidov added a commit that referenced this pull request Aug 22, 2018
alexey-milovidov added a commit that referenced this pull request Aug 24, 2018
Moved "setcap" from init script to postinst #2482
alexey-milovidov added a commit that referenced this pull request Aug 30, 2018
alexey-milovidov added a commit that referenced this pull request Aug 30, 2018
alexey-milovidov added a commit that referenced this pull request Aug 31, 2018
alexey-milovidov added a commit that referenced this pull request Aug 31, 2018
alexey-milovidov added a commit that referenced this pull request Aug 31, 2018
alexey-milovidov added a commit that referenced this pull request Sep 6, 2018
alexey-milovidov added a commit that referenced this pull request Sep 8, 2018
Fixed usage of query scope in TCPHandler #2482
@Aricliang
Copy link

system.query_log

@Felixoid Felixoid deleted the CLICKHOUSE-2910 branch April 10, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants