Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash screen background by theme #78

Closed
nvllz opened this issue Feb 10, 2024 · 7 comments
Closed

Splash screen background by theme #78

nvllz opened this issue Feb 10, 2024 · 7 comments
Assignees

Comments

@nvllz
Copy link

nvllz commented Feb 10, 2024

Hi, I just got flashed when wanted to search for some term clarification within your great app. For better experience, the splash screen background color should match the current theme setting.

@yamin8000 yamin8000 self-assigned this Feb 10, 2024
@yamin8000
Copy link
Owner

Hi, I just got flashed when wanted to search for some term clarification within your great app. For better experience, the splash screen background color should match the current theme setting.

Hi.
Thank you.
I just want to clarify something, did you experience a white flash during launch/splash or after the app is opened and you're searching for a new term?

@nvllz
Copy link
Author

nvllz commented Feb 10, 2024

It's the splash screen (background when opening the app) which is always white regardless of the current theme. When using dark theme it would be good to have it black to prevent such cases.

@yamin8000
Copy link
Owner

It's the splash screen (background when opening the app) which is always white regardless of the current theme. When using dark theme it would be good to have it black to prevent such cases.

Hmm. That never happens to me. Which version of Android you are using?

@nvllz
Copy link
Author

nvllz commented Feb 10, 2024

Android 13, you can learn more here: https://developer.android.com/develop/ui/views/launch/splash-screen

@yamin8000
Copy link
Owner

Android 13, you can learn more here: https://developer.android.com/develop/ui/views/launch/splash-screen

Thanks. I'll look into it.

@yamin8000
Copy link
Owner

Android 13, you can learn more here: https://developer.android.com/develop/ui/views/launch/splash-screen

TL;DR;
Hell, I added it anyway.

One big problem with that splash screen is its complete disregard for the Jetpack Compose Theme System. This type of Splash Screen still relies on XML configuration while Jetpack Compose apps' colors are defined inside Kotlin codes so its config is always prone to be out of sync with app theme colors also it's not aware of the app's current theme so its understanding of whether an app is in dark mode or light mode is based on device dark/light setting.

@nvllz
Copy link
Author

nvllz commented Feb 21, 2024

You are right, I learned it recently too. But it's still a big upgrade, will definitely prevent those unexpected flashes at night.

Thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants