-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splash screen background by theme #78
Comments
Hi. |
It's the splash screen (background when opening the app) which is always white regardless of the current theme. When using dark theme it would be good to have it black to prevent such cases. |
Hmm. That never happens to me. Which version of Android you are using? |
Android 13, you can learn more here: https://developer.android.com/develop/ui/views/launch/splash-screen |
Thanks. I'll look into it. |
TL;DR; One big problem with that splash screen is its complete disregard for the Jetpack Compose Theme System. This type of Splash Screen still relies on XML configuration while Jetpack Compose apps' colors are defined inside Kotlin codes so its config is always prone to be out of sync with app theme colors also it's not aware of the app's current theme so its understanding of whether an app is in dark mode or light mode is based on device dark/light setting. |
You are right, I learned it recently too. But it's still a big upgrade, will definitely prevent those unexpected flashes at night. Thanks for your efforts! |
Hi, I just got flashed when wanted to search for some term clarification within your great app. For better experience, the splash screen background color should match the current theme setting.
The text was updated successfully, but these errors were encountered: