Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmaintained (?) + fork #12

Closed
sigaloid opened this issue Oct 23, 2021 · 4 comments
Closed

Unmaintained (?) + fork #12

sigaloid opened this issue Oct 23, 2021 · 4 comments

Comments

@sigaloid
Copy link
Contributor

sigaloid commented Oct 23, 2021

While anxiously awaiting the return of @xvxx from a fishing expedition [1], I forked the repo and made a few improvements. Glad to contribute upstream when the maintainer returns, but until then, I won't make a bunch of PR's for each one.
I accepted #10 #11 #7 #6 + a few others. a list:

Link: https://github.com/sigaloid/vial

1: image

@JEBailey
Copy link
Contributor

I reached out via email and apparently Chris had decided to take a year off. Hopefully, he'll return early since his stuff has started to gain some traction

@sigaloid
Copy link
Contributor Author

Thanks, that makes me happy, hopefully some of these fixes can be upstreamed. :D

@sigaloid
Copy link
Contributor Author

sigaloid commented Jan 8, 2022

Hi @xvxx, I have not implemented compression correctly and as-is it's disabled (the code is set to use compression if the feature is enabled but I've removed the feature in Cargo.toml so it can't be enabled). If you're willing to merge the changes (there's some conflicts 😞) I have created a PR: #15

It's relatively large and I can answer any questions you may have (and of course change anything as you see fit) if you decide you want to merge.

@xvxx
Copy link
Owner

xvxx commented Nov 16, 2022

Hi @sigaloid, I merged some of your edits, thank you! Happy to review any other PRs you have.

@xvxx xvxx closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants