Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bell() function never gets called #853

Closed
npezza93 opened this issue Aug 6, 2017 · 2 comments
Closed

bell() function never gets called #853

npezza93 opened this issue Aug 6, 2017 · 2 comments
Labels
help wanted type/enhancement Features or improvements to existing features
Milestone

Comments

@npezza93
Copy link
Contributor

npezza93 commented Aug 6, 2017

It doesn't appear the bell() function is ever getting called. I was trying to play with what sound gets played but I couldn't get the function to be called. I made sure to set visualBell and popOnBell to true. Is there a config I am missing?

In Terminal.app if you press the down arrow you get a sound and same goes with Hyper.

Details

  • Browser and browser version:
  • OS version: MacOS Sierra
  • xterm.js version: latest

Steps to reproduce

  1. Press the down arrow
Terminal.prototype.bell = function() {
  if (!this.visualBell) return;
  var self = this;
  this.element.style.borderColor = 'white';
  setTimeout(function() {
    self.element.style.borderColor = '';
  }, 10);
  if (this.popOnBell) this.focus();
};
@Tyriar
Copy link
Member

Tyriar commented Aug 7, 2017

You're right, it doesn't seem to do much currently.

Related: term.js added a 'bell' event after this was forked to allow custom sounds chjj/term.js@877d6fe

@Tyriar Tyriar added the feature label Aug 7, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Aug 19, 2017
@Tyriar Tyriar closed this as completed Aug 19, 2017
@Tyriar Tyriar added type/enhancement Features or improvements to existing features and removed type/feature labels Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type/enhancement Features or improvements to existing features
Projects
None yet
Development

No branches or pull requests

2 participants