Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help providing the minify files #602

Closed
sufuf3 opened this issue Mar 15, 2017 · 5 comments
Closed

Help providing the minify files #602

sufuf3 opened this issue Mar 15, 2017 · 5 comments
Labels
type/proposal A proposal that needs some discussion before proceeding

Comments

@sufuf3
Copy link

sufuf3 commented Mar 15, 2017

Hi @sourcelair ,
We are cdnjs team, we're going to host this library.
Could you please provide xterm.min.js, xterm.min.css and the minify files under dist/addons?

If there is any suggestion, please let me know.
Thank you.

cdnjs/cdnjs#10764

@Tyriar
Copy link
Member

Tyriar commented Mar 15, 2017

@sufuf3 We actually plan to remove dist/ all together as built (unminified) files are published to npm in lib/ (see #420 for more context).

You could probably write a script pretty easily that clones the git repo at a release tag, runs npm i && npm run build and then minifies ./build/* with your library of choice. FYI 2.4.0 is now the latest.

@parisk maybe we should add a minify gulp task and upload those assets to releases for use cases like this and to enable quick download without a package manager?

@Tyriar Tyriar added the type/proposal A proposal that needs some discussion before proceeding label Mar 15, 2017
@parisk
Copy link
Contributor

parisk commented Mar 15, 2017

Hi @sufuf3, thanks for offering to host the library 👍 .

As @Tyriar already said, we plan to remove the dist/ directory, but what we plan to do is create an extra repository to keep these files (as described in #406).

Would it be OK for you if these files resided in https://github.com/xtermjs/dist (or something like that), instead of this directory?

If yes, I can move with setting this up immediately.

@parisk
Copy link
Contributor

parisk commented Mar 16, 2017

Another solution (as @Tyriar proposed) would be uploading an archive of all build artefacts in GitHub Releases.

Would this work as well?

@sufuf3
Copy link
Author

sufuf3 commented Mar 16, 2017

Now, we will host this library from this GitHub repository and use minify tool by uglify-js.
When this library change to another repository, we will update the file structure and auto-update info.
Thank you very much.

@Tyriar
Copy link
Member

Tyriar commented Mar 16, 2017

I think we can close in favor of #406 then as you have a workaround, thanks for including in cdnjs!

@Tyriar Tyriar closed this as completed Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal A proposal that needs some discussion before proceeding
Projects
None yet
Development

No branches or pull requests

3 participants