Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Linkifier jsdom tests #550

Closed
Tyriar opened this issue Feb 17, 2017 · 1 comment
Closed

Add Linkifier jsdom tests #550

Tyriar opened this issue Feb 17, 2017 · 1 comment
Assignees
@Tyriar
Labels
type/debt Technical debt that could slow us down in the long run

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 17, 2017 •
edited
Loading

Need to cover the content of this PR: #538 (comment)
@Tyriar Tyriar added the type/enhancement Features or improvements to existing features label Feb 17, 2017
@Tyriar Tyriar self-assigned this Feb 17, 2017
@Tyriar Tyriar mentioned this issue Feb 17, 2017
Merged
@Tyriar Tyriar changed the title Add Linkifier phantom tests Add Linkifier jsdom tests Mar 1, 2017
@Tyriar Tyriar added type/debt Technical debt that could slow us down in the long run and removed type/enhancement Features or improvements to existing features labels Apr 4, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Jun 1, 2018

Linkifier tests are pretty good now, DOM tests don't make as much sense after canvas.

@Tyriar Tyriar closed this as completed Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tyriar