Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Impossible" errors #789

Open
ndw opened this issue Dec 26, 2024 · 4 comments
Open

"Impossible" errors #789

ndw opened this issue Dec 26, 2024 · 4 comments

Comments

@ndw
Copy link
Contributor

ndw commented Dec 26, 2024

I'm using this issue to track errors that are in the specification(s) but are unlikely to be raised. I'm not sure we need to do anything about them, but the test suite reports how many tests we have for error conditions. If an error is never raised, then that's a little misleading with respect to coverage...

@ndw
Copy link
Contributor Author

ndw commented Dec 26, 2024

err:XS010, a pipeline contains a step whose specified inputs, outputs, and options do not match the for steps of that type

We have more specific error codes for each of those conditions.

@ndw
Copy link
Contributor Author

ndw commented Dec 26, 2024

err:XS0027, It is a static error if an option is specified with both the shortcut form and the long form.

I guess this one isn't impossible, but I think it's subsumed by err:XS0080, it is a static error to include more than one p:with-option with the same option name as part of the same step invocation.

My implementation transforms shortcut options into "regular" options, so I always get err:XS0080.

@xml-project
Copy link
Member

  1. My implementation raises XS0010 only for a p:viewport with more than one p:output, but I guess XS0100 would be ok too.
  2. I think XS0027 might be more helpful, but my implementation does the same as yours.

@ndw
Copy link
Contributor Author

ndw commented Dec 26, 2024

err:XS0048, It is a static error to use a declared step (an extension step without a body) as a compound step

I throw XS0100 because I know what all the compound steps are and I reject the attempt to construct the invalid compound step long before I look at whether or not the wrapper is declared as an atomic, extension step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants