Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ignores" option doesn't work, but "ignore" does. #358

Closed
papiro opened this issue Dec 20, 2018 · 0 comments
Closed

"ignores" option doesn't work, but "ignore" does. #358

papiro opened this issue Dec 20, 2018 · 0 comments

Comments

@papiro
Copy link

papiro commented Dec 20, 2018

This seems so strange to me. I tried the ignores option, per https://github.com/xojs/xo#ignores, with absolutely no effect, as such (in package.json):

"xo": {
    "ignores": ["**/*.spec.js"],
...

But it had no effect whatsoever. It had me scratching my head for a good 45 minutes. Then I did some searching and found this issue: #65 which is actually using a ignore option! So I changed mine and it suddenly started working!... But then I saw this issue: #244 and the ignores option is being used and seems the issue was resolved...

I'm totally confused. But I'm keeping it as ignore for now, since it works, even though the docs and several examples have it as ignores. What should it be?

@papiro papiro closed this as completed Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant