Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercept all incoming S2S stanzas #366

Closed
smokku opened this issue Feb 19, 2017 · 5 comments
Closed

Intercept all incoming S2S stanzas #366

smokku opened this issue Feb 19, 2017 · 5 comments

Comments

@smokku
Copy link
Contributor

smokku commented Feb 19, 2017

I'd like a way to process all incoming S2S stanzas at central point, not having to Router.register every domain separately.

So far I do it by monkey-patching DomainContext.prototype.receive, but this is a brittle solution.

I would gladly code a PR, but first I would like to discuss a preferred solution.
I noticed "Define and implement a simple/basic 'plugin' mechanism (catch in/out stanzas)" on Roadmap - should this wait until this feature is implemented?

@sonnyp
Copy link
Member

sonnyp commented Feb 22, 2017

@smokku as you've seen node-xmpp is under a rewrite but to reduce the scope; at the moment only client, component and core libraries are concerned but if you're willing to work on node-xmpp-server rewrite I'd be happy to help.

The alternative is to maintain node-xmpp-server as it is.

Let me know which way you'd prefer and we can discuss it.

@smokku
Copy link
Contributor Author

smokku commented Feb 22, 2017

I would gladly help. node-xmpp-server is not that big.

Any TODO? Pointers? Flow?

@sonnyp
Copy link
Member

sonnyp commented Feb 23, 2017

@smokku give me a couple of days to think about it and put everything in order

I tried to add you to my XMPP roster but didn't get a handshake yet, is your JID on your personal website up to date?

@smokku
Copy link
Contributor Author

smokku commented Feb 23, 2017

I am rarely online. Please try again. :)

@sonnyp
Copy link
Member

sonnyp commented Jan 9, 2019

node-xmpp is now deprecated

@sonnyp sonnyp closed this as completed Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants