Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update windows ci to server 2025 #6270

Closed
wants to merge 1 commit into from
Closed

update windows ci to server 2025 #6270

wants to merge 1 commit into from

Conversation

c8ef
Copy link
Member

@c8ef c8ef commented Feb 2, 2025

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

@c8ef
Copy link
Member Author

c8ef commented Feb 2, 2025

It appears that they both come with Visual Studio Enterprise 2022, so let's close for now.

@c8ef c8ef closed this Feb 2, 2025
@waruqi
Copy link
Member

waruqi commented Feb 2, 2025

现在出 vs2025了? 跑 2019 是为了测低版本的 vs 2019 下的兼容性,并且跟 build-artifacts 保持一致,出最低 toolset 版本的 二进制,保持较好的兼容性,因为 msvc 的 toolset 是向下兼容的。

如果这里删了,可能会出现,ci 通过,build_artifacts 上没通过,一些问题发现不了,降低预编译包出包率。

如果真有2025了,建议还是跑 2019-2025 覆盖高低两个大版本,或者干脆三个版本一起跑

@c8ef c8ef deleted the windows2025 branch February 2, 2025 10:12
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Is VS2025 now? The running 2019 is to measure the compatibility of the low version of VS 2019, and it is consistent with the BUILD-Artifacts. The lowest Toolset version of the binary is maintained, which maintains good compatibility, because the Toolset of MSVC is downward compatible.

If it is deleted here, it may appear, CI passes, and it may not be approved on build_artifacts. Some problems cannot be found.

If there is really 2025, it is recommended to run 2019-2025 to cover the two large versions of the high, or simply run together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants