Fix numbers types #605
Draft
Fix numbers types #605
+129
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wismill
added
compile-keymap
Avoid implicit conversion from `int64_t`.
The `Resolve*` functions do not always initialize the parameters that they can modify, so it is safer to always initialize them at the call site.
wismill
force-pushed
the
xkbcomp/fix-numbers
branch
from
24b0e78 to
01b895e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, made public only to make you aware I am working on this.
Follow-up of #604 that is mostly a refactor of the parser for integers. Will probably split the minor refactoring in another PR.
Fixes #594