Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-edit Ad campaigns: tags not saving after edit tags #3589

Open
ifarzana opened this issue Feb 12, 2025 · 1 comment
Open

Multi-edit Ad campaigns: tags not saving after edit tags #3589

ifarzana opened this issue Feb 12, 2025 · 1 comment
Labels
Milestone

Comments

@ifarzana
Copy link

When editing tags for multiple selected Ad type campaign items and clicking save, the changes do not persist as expected. Instead, an error message appears prompting the user to select a display ID.

Steps to reproduce

  • Navigate to the Campaigns page.
  • Select multiple Ad type campaigns.
  • Click on With selected drop-down and choose Edit tags.
  • Enter a new tag name.
  • Click Save twice.

Expected behaviour
The updated tags should be correctly saved and reflected on all selected campaign items.

Actual behaviour
Tags are not saved as expected.
After clicking Save twice, an error appears stating:
Please select one or more displays.

Additional notes
The issue seems to occur specifically when attempting to edit tags for the type Ad. Editing tags for List type campaigns do not seem to trigger this issue.

Image

@ifarzana ifarzana added the bug label Feb 12, 2025
@maurofmferrao maurofmferrao self-assigned this Feb 13, 2025
@maurofmferrao maurofmferrao modified the milestones: 4.2.1, 4.2.2 Feb 13, 2025
@maurofmferrao maurofmferrao removed their assignment Feb 13, 2025
@maurofmferrao
Copy link
Member

This seems to be a validation happening in lib/Controller/Tag.php -> editMultiple for the Ad Campaigns that prevents adding the tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants