From ef9060a8572251ff9bd5c52e8794b7e2b3335ca9 Mon Sep 17 00:00:00 2001 From: TomTirapani Date: Thu, 3 Oct 2024 15:55:37 +0100 Subject: [PATCH 1/2] Add fallback to deprecated MouseEvent.which property to workaround Safari issue --- desktop/cmp/panel/impl/dragger/DraggerModel.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/desktop/cmp/panel/impl/dragger/DraggerModel.ts b/desktop/cmp/panel/impl/dragger/DraggerModel.ts index 62b5f4bc02..ca479ec97f 100644 --- a/desktop/cmp/panel/impl/dragger/DraggerModel.ts +++ b/desktop/cmp/panel/impl/dragger/DraggerModel.ts @@ -254,7 +254,9 @@ export class DraggerModel extends HoistModel { } private isValidMouseEvent(e) { - return e.buttons && e.buttons !== 0; + // Note: We fall back to deprecated 'which' to work around a Safari issue where `buttons` + // was not being set. We may be able to remove in the future. + return (e.buttons && e.buttons !== 0) || (e.which && e.which !== 0); } private isValidTouchEvent(e) { From ec548f0cf975234d5c50f6fbbd7d01ab629b683c Mon Sep 17 00:00:00 2001 From: TomTirapani Date: Thu, 3 Oct 2024 16:13:13 +0100 Subject: [PATCH 2/2] Added CHANGELOG entry --- CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c5932ed846..8b76adb3ef 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,10 +2,13 @@ ## 69.0.0-SNAPSHOT - unreleased +### 🐞 Bug Fixes + +* Added a workaround for a bug where Panel drag resizing was broken in Safari. ### 💥 Breaking Changes (upgrade difficulty: 🟢 LOW ) * The `INITIALIZING` AppState has been replaced with more fine-grained states (see below). This -is not expected to effect any applications. +is not expected to affect any applications. ### 🎁 New Features