Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabContainer active tab can become out of sync with the router state #451

Closed
haynesjm42 opened this issue Jul 17, 2018 · 0 comments
Closed
Assignees
Labels

Comments

@haynesjm42
Copy link
Member

When changing the active tab via setActiveTabId (such as with TabSwitcher), the active tab is set before attempting to navigate via the router. It is possible that the route change would be rejected (via middleware or a canDeactivate handler) and in that case the currently rendered tab is out of sync with the router state. When using routing, the TabContainer active tab should probably only be set via router state changes to ensure they remain in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant