Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automate sync of ABI files from v1-core to xeon-dapp #3

Merged
merged 6 commits into from
Jul 28, 2024

Conversation

heyJonBray
Copy link
Owner

the purpose of this PR is to ensure that ABI files are in sync between v1-core and xeon-dapp now that the codebase is modularized.

updates

add a sync-abi-to-dapp workflow to run on pushes to main branch that:

  • checks for changes in the abi/ directory
  • if found, syncs files to xeon-dapp/src/abi/ on the ci/abi-sync branch
    • using SSH to securely handle the transfer

considerations

commits are made to the ci/abi-sync branch in the xeon-dapp repo
all branches in our codebases that begin with "ci/" are protected so that:

  • only CI workflows can commit to them
  • a PR is required to push to main
  • all status checks must pass

@heyJonBray heyJonBray added type: enhancement Updating an existing feature scope: tools Scripts for supporting dev work, generating config and build artifacts, etc. labels Jul 28, 2024
@heyJonBray heyJonBray requested a review from wellytg July 28, 2024 07:05
@heyJonBray heyJonBray self-assigned this Jul 28, 2024
Copy link

@wellytg wellytg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this code check for changes and create new branch if they exist? And PR

@heyJonBray
Copy link
Owner Author

@wellytg yes, it checks for changes in the ABI directory of this repo, and then makes a new branch and PR on the dapp repo with the updated files

@heyJonBray heyJonBray merged commit 78766bd into main Jul 28, 2024
1 check passed
@heyJonBray heyJonBray deleted the feat/abi-automation branch July 28, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: tools Scripts for supporting dev work, generating config and build artifacts, etc. type: enhancement Updating an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants