chainlocks: Relay clsig inv only after bestChainLock(Hash) are assigned (dashpay#3990)

UdjinM6 · web-flow · commit 77e9a4a83beb · 2021-02-16T16:54:19.000+01:00
Fixes a race condidion when we might reply with `notfound` to other nodes because we might still be waiting for locks here.
diff --git a/src/llmq/quorums_chainlocks.cpp b/src/llmq/quorums_chainlocks.cpp
@@ -135,13 +135,13 @@ void CChainLocksHandler::ProcessNewChainLock(const NodeId from, const llmq::CCha
         return;
     }
 
-    g_connman->RelayInv(clsigInv, LLMQS_PROTO_VERSION);
-
     {
         LOCK2(cs_main, cs);
         bestChainLockHash = hash;
         bestChainLock = clsig;
 
+        g_connman->RelayInv(clsigInv, LLMQS_PROTO_VERSION);
+
         const CBlockIndex* pindex = LookupBlockIndex(clsig.blockHash);
         if (!pindex) {
             // we don't know the block/header for this CLSIG yet, so bail out for now

Original file line number	Diff line number	Diff line change
`@@ -135,13 +135,13 @@ void CChainLocksHandler::ProcessNewChainLock(const NodeId from, const llmq::CCha`
`135`	`135`	`return;`
`136`	`136`	`}`
`137`	`137`
`138`		`- g_connman->RelayInv(clsigInv, LLMQS_PROTO_VERSION);`
`139`		`-`
`140`	`138`	`{`
`141`	`139`	`LOCK2(cs_main, cs);`
`142`	`140`	`bestChainLockHash = hash;`
`143`	`141`	`bestChainLock = clsig;`
`144`	`142`
	`143`	`+ g_connman->RelayInv(clsigInv, LLMQS_PROTO_VERSION);`
	`144`	`+`
`145`	`145`	`const CBlockIndex* pindex = LookupBlockIndex(clsig.blockHash);`
`146`	`146`	`if (!pindex) {`
`147`	`147`	`// we don't know the block/header for this CLSIG yet, so bail out for now`