Rename examples to cli #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMHO https://github.com/xdf-modules/xdf-tagger could also live here, rather than in its own repo. It is very similar in scope to the other "examples". |
|
@sappelhoff yes, I think so too! Would you be willing to submit a separate PR? I'd like to merge this one before adding new things. |
sure, I could do that. However, I think this should go hand in hand with updating the README and then archiving said repo, to avoid duplicates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
pyxdf.examplesshould be namedpyxdf.cli, as this is what it really contains.In addition, I've enforced a line length of 88 (default of Black/Ruff).