-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong url calculated (2x base urls in mpd) #283
Comments
@peak3d |
Looks like the second BaseURL is malformed - only one forward slash so maybe it should reject it based on that? |
@matthuisman I'm really unsure if I want to spend time on implementing logic to detect such malformed stuff. If it is important for you, you still could route the mpd fetch through your plugin and repair the mpd file by yourself. |
Sorry, I was unaware it was malformed.
Your saying a mpd file should never have 2x base URLs? Its against the
specification?
I assumed it was just a feature we hadn't seen yet. Eg. A fallback if the
first is down or players pick one at random to reduce loads.
It plays via their android app (probably shaka) and via website.
In the inputstream code, it appears its just appending both base URLs
together.
I was thinking when its looping the tags that it could just skip the
baseurl tag if it already had a base URL set.
UPDATE 1:
Oh, just spotted glens comment and the missing slash!
Ill fix the slash and see if IA can then handle it (with 2x valid base URLs)
Hopefully the provider will fix it their end too
UPDATE 2:
Ok, looks like two base URLs is valid.
google/ExoPlayer#771
Yes in this case the 2nd is malformed but ideally IA would be ignoring it
anyway as it has already selected the first?
Obviously the failover logic is a big ask, but maybe for now just selecting
the first one?
I think something like this could be used by providers to try to kill kodi
addons.
Putting rubbish 2nd base URLs that other players will ignore but breaks
kodi playback.
What do you think?
UPDATE 3:
Merged all my comments into single reply (I was on email last night and couldn't edit them)
|
OK, the provider seems to have fixed the bad base urls. IA plays this fine, but it seems to use the 2nd base-url for segments I assume as it's looping elements, it just overrides the first base-url it had found. Is this desired behaviour? |
I'll be closing this issue and starting a new issue to implement multiple base urls |
New issue: |
It has 2x base-urls in the mpd (attached), not sure if that is what is causing the issue.
One appears to be a back-up.
The url is calculates is:
https://spark.akamaized.net/dash/live/2003222-b/spark/d2150a9c-6747-46f3-92bb-75cc6f062723/startover/5982918e8f79bdb74efcd16275d0653ada1b9302/https:/spark.akamaized.net/dash/live/2003222/spark/d2150a9c-6747-46f3-92bb-75cc6f062723/startover/5982918e8f79bdb74efcd16275d0653ada1b9302/../../462c5cc3-fc84-4d0f-aec8-b68dda344331/1080p-30fps-6000kbps-init.mp4
The correct url should be:
https://spark.akamaized.net/dash/live/2003222-b/spark/d2150a9c-6747-46f3-92bb-75cc6f062723/462c5cc3-fc84-4d0f-aec8-b68dda344331/1080p-30fps-6000kbps-init.mp4
The url to mpd is:
https://spark.akamaized.net/dash/live/2003222-b/spark/d2150a9c-6747-46f3-92bb-75cc6f062723/startover/5982918e8f79bdb74efcd16275d0653ada1b9302/master.mpd
Debug log and mpd attached
master.mpd.txt
kodi.log.txt
Appears maybe Inputstream just needs to select the first base url and use that?
The text was updated successfully, but these errors were encountered: