Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we only show guesses that matter? #330

Closed
malmans2 opened this issue Apr 22, 2022 · 0 comments · Fixed by #331
Closed

Should we only show guesses that matter? #330

malmans2 opened this issue Apr 22, 2022 · 0 comments · Fixed by #331

Comments

@malmans2
Copy link
Member

Right now guess_coord_axis(verbose=True) prints all matches, even for variables that already have the appropriate attributes.
Should we only show the guesses that matter (i.e., the guess for variables with missing attributes)?

I think it gets even more confusing when multiple guesses are shown, such as this:

I think 'isobaricInhPa' is of type 'Z'. It matched re.compile('(z|nav_lev|gdep|lv_|[o]*lev|bottom_top|sigma|h(ei)?ght|altitude|depth|isobaric|pres|isotherm)[a-z_]*[0-9]*')
I think 'isobaricInhPa' is of type 'X'. It matched re.compile('x|i|nlon|ni')

The variable is correctly assigned to the Z axis, but I find the print a bit confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant