Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust MultiTargets imports #17618

Closed
rolfbjarne opened this issue Feb 24, 2023 · 1 comment
Closed

Adjust MultiTargets imports #17618

rolfbjarne opened this issue Feb 24, 2023 · 1 comment
Labels
enhancement The issue or pull request is an enhancement
Milestone

Comments

@rolfbjarne
Copy link
Member

From here:

@dsplaisted I changed it to only add to AfterMicrosoftNETSdkTargets if the file to be added actually exists: xamarin/xamarin-macios@bef4867, I suppose that should work as well?

It probably works, but it looks like the import path depends on a property that is set in the workloads, so when the workloads aren't imported the property is blank so its trying to import from a path relative to the workload manifest targets instead. So it's not checking the existence of the file it's actually trying to import, it's checking a different file path which will probably never exist.

It seems like it would be more precise to check if the property was set, or to move the logic to the import targets where you know it will be set.

Ref: dotnet/sdk#30230

@rolfbjarne rolfbjarne added the enhancement The issue or pull request is an enhancement label Feb 24, 2023
@rolfbjarne rolfbjarne added this to the Future milestone Feb 24, 2023
@rolfbjarne
Copy link
Member Author

We don't import the MultiTargets file anymore, so this doesn't apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue or pull request is an enhancement
Projects
None yet
Development

No branches or pull requests

1 participant