[Bytecode] Hide Kotlin synthetic default constructors. #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
kotlin-defaultconstructor
branch
from
4d8b8aa to
322ed90
Compare
jonpryor
reviewed
Aug 28, 2020
| return false; | ||
|
|
||
| // Final parameter is DefaultConstructorMarker | ||
| if (parameters.Last ().Type.TypeSignature != "Lkotlin/jvm/internal/DefaultConstructorMarker;") |
There was a problem hiding this comment.
.Last() involves an IEnumerable allocation & enumeration. parameters [parameters.Length-1] would be more efficient, and in keeping with the return statement.
jonpryor
pushed a commit
that referenced
this pull request
Aug 31, 2020
…700) Fixes: #694 Context: dotnet/android#3776 When using a Kotlin default constructor like: class MaterialDialog( val windowContext: Context, val dialogBehavior: DialogBehavior = DEFAULT_BEHAVIOR ) : Dialog(windowContext, inferTheme(windowContext, dialogBehavior)) { ... } Kotlin will create 2 constructors, the "real" one, and a synthetic one denoting which constructor is the default constructor using a `kotlin.jvm.internal.DefaultConstructorMarker` parameter: <constructor deprecated="not deprecated" final="false" name="MaterialDialog" static="false" visibility="public" bridge="false" synthetic="false" jni-signature="(Landroid/content/Context;Lcom/afollestad/materialdialogs/DialogBehavior;)V"> <parameter name="windowContext" type="android.content.Context" jni-type="Landroid/content/Context;" not-null="true"/> <parameter name="dialogBehavior" type="com.afollestad.materialdialogs.DialogBehavior" jni-type="Lcom/afollestad/materialdialogs/DialogBehavior;" not-null="true"/> </constructor> <constructor deprecated="not deprecated" final="false" name="MaterialDialog" static="false" visibility="public" bridge="false" synthetic="true" jni-signature="(Landroid/content/Context;Lcom/afollestad/materialdialogs/DialogBehavior;ILkotlin/jvm/internal/DefaultConstructorMarker;)V"> <parameter name="p0" type="android.content.Context" jni-type="Landroid/content/Context;"/> <parameter name="p1" type="com.afollestad.materialdialogs.DialogBehavior" jni-type="Lcom/afollestad/materialdialogs/DialogBehavior;"/> <parameter name="p2" type="int" jni-type="I"/> <parameter name="p3" type="kotlin.jvm.internal.DefaultConstructorMarker" jni-type="Lkotlin/jvm/internal/DefaultConstructorMarker;"/> </constructor> Additionally, the `kotlin.jvm.internal.DefaultConstructorMarker` type is not available in the `Xamarin.Kotlin.StdLib` NuGet package, because the type is `internal`. Consequently, when trying to bind the constructor, `ApiXmlAdjuster` reports this "error": Error while processing '[Constructor] MaterialDialog(android.content.Context p0, com.afollestad.materialdialogs.DialogBehavior p1, int p2, kotlin.jvm.internal.DefaultConstructorMarker p3)' in '[Class] com.afollestad.materialdialogs.MaterialDialog': Type 'kotlin.jvm.internal.DefaultConstructorMarker' was not found. This is actually good, as we shouldn't bind this synthetic constructor, but we should detect this Kotlin-ism and not emit the "error", as it misleads users into thinking they need to do something to fix it. Update `Xamarin.Android.Tools.Bytecode` to *hide* constructors for which the final two parameter types are `int, DefaultConstructorMarker`, thus ensuring that `ApiXmlAdjuster` & co. won't process such members or attempt to resolve the unresolvable `DefaultConstructorMarker` type.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #694.
Prevent "errors" like this from being displayed to the user by recognizing the synthetic default constructors that Kotlin generates and hiding them: