[XAT.Bytecode] Kotlin internal interfaces need to be set to package-private #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
that referenced
this pull request
May 18, 2020
Context: dotnet/android#4661 In 439bd83, we made a change to hide Kotlin `internal` members as we shouldn't be binding them. However a `public class` can inherit from an `internal interface`, so we need to emit those interfaces. Instead, emit `internal interface` types as "package private" types; `visibility=""` in `api.xml` parlance. This allows us to resolve the `interface` and thus successfully bind the `class`. In C#-land, the `interface` is not actually bound and the C# class doesn't actually implement it. This has no effect to the public API end user, who shouldn't be seeing the `internal interface` anyways. If a user really wants to publicly expose the `interface`, its `visibility` can be changed via `metadata`. ***Note***: Changing the `visibility` of a type may result in subsequent Java Callable Wrapper generation errors, if/when a Java Callable Wrapper attempts to implement the package-private type.
|
Release Notes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#4661
In 439bd83 we made a change to hide Kotlin
internalmembers as we shouldn't be binding them. However apublic classcan inherit aninternal interface, so we need to emit those interfaces.This change emits the
internal interfaceaspackage-private(visibility=""inapi.xmlparlance). This allows us to resolve theinterfaceand thus successfully bind theclass.In C#-land, the
interfaceis not actually bound and the C# class doesn't actually implement it. This has no effect to the public API end user, who shouldn't be seeing theinternal interfaceanyways . If a user really wants to publicly expose theinterface, itsvisibilitycan be changed viametadata.