Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Can't actually add a reference to Xamarin.Auth.Extensions in the PCL #229

Closed
dagostinelli opened this issue Sep 13, 2017 · 5 comments
Closed

Comments

@dagostinelli
Copy link

Xamarin.Auth.Extensions Issue

This might be related to this #171

Version

<package id="Xamarin.Auth" version="1.5.0.3" targetFramework="portable45-net45+win8+wp8+wpa81" />
<package id="Xamarin.Auth.Extensions" version="1.5.0.3" targetFramework="portable45-net45+win8+wp8+wpa81" />
<package id="Xamarin.Forms" version="2.3.4.270" targetFramework="portable45-net45+win8+wp8+wpa81" />

Steps to reproduce

  1. Attempt to install the Xamarin.Auth.Extensions package after already installing Xamarin.Auth nuget package. Do this in a PCL.
  2. Look at your project References. Notice anything missing? What's missing is the extensions dll.

I attempted to add the DLL manually. It turns out that the DLL in the Xamarin.Auth.Extensions package is called Xamarin.Auth. Bug?

Needless to say, the result is that and object called OAuth2AuthenticatorExtensions is not available for use in source code.

Comments

While we are on it...

  • Having this whole refresh token stuff outside of the main Xamarin.Auth project seems really odd. It's part of the spec Maybe it wasn't part of the spec at one time? I read this link and this link about the rationale behind separating it. Still... seems a like this needs to get merged now.
@moljac
Copy link
Member

moljac commented Sep 13, 2017

@dagostinelli
The decision to move it outside of Xamarin.Auth was based on one pretty old discussion when only implicit flow was "OK" for mobile/installed/native apps and refresh-token concept makes no sense with implicit flow.

I work on moving refresh token back to Xamarin.Auth and moving AccountStore out of OAuth (Xamarin.Auth) library, because storing tokens (except long living refresh token) is not considered to be good security practice.

The main problem is that I never planned to be OAuth expert and now need a lot to catch up. Besides coding and fixing bugs, I try to get deeper understanding of OAuth.

@dagostinelli
Copy link
Author

dagostinelli commented Sep 14, 2017

@moljac That makes sense about the AccountStore as well. It's a pretty useful library in general. Will it be a new plugin?

As for getting volun-told to become the resident OAuth expert.... I understand. This is what happens to people who do a good job (@moljac) 👍 You get rewarded with more work. 😃

@SOHODeveloper
Copy link

@moljac I too would really love to see a separate AuthStore package that targeted .NetStanadard 2.0.

@synthphonic
Copy link

found this while looking for a separate a secure storage nuget package

https://github.com/sameerkapps/SecureStorage

@newky2k
Copy link
Contributor

newky2k commented Sep 3, 2018

The name of the dll for the extensions library has now been changed -> https://github.com/xamarin/Xamarin.Auth/blob/master/nuget/Xamarin.Auth.Extensions.nuspec

@newky2k newky2k closed this as completed Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants