New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement code structure/style feedback #392

Open

garemoko opened this issue Jan 8, 2019 · 0 comments

Labels

Contributor

garemoko commented Jan 8, 2019

Two code review comments on a merged PR that it would be good to address at some point (not urgent).

https://github.com/xAPI-vle/moodle-logstore_xapi/pull/367/files/08e72bdecc52fe26a4208e08a8dc82d169f8b80b#r245915624

https://github.com/xAPI-vle/moodle-logstore_xapi/pull/367/files/08e72bdecc52fe26a4208e08a8dc82d169f8b80b#r245914290

ryasmi added the refactor label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment