-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setter for ionization potential #325
Comments
This should be done in tandem with #323 |
Are there significantly different values or precisions from different atomic databases? I guess I'm wondering why a setter is needed for ionization potential, as it should just be a fundamental property of an ion. |
That's a fair point. The only reason I proposed to do it this way is because the ionization potential data is structured very similarly to the ioneq and abundance data in the database. In practice, I think you're right that this data is unlikely to change much and not be very variable. There is only one file for these values in the database. The footer for this file does list several different sources:
Whether these will ever be or need to be updated I do not know. |
Perhaps one reasonable thing would be to allow different files for input, so as to allow different sources for the values (CHIANTI, NIST, AtomDB, whatever). I'm not sure it would make sense to allow the user to set the values manually, like |
Yep that's the kind of use case I had in mind. With #342, this should now be possible. |
When making an
Ion
, it is possible to set the abundance through a keyword argument. This keyword argument can be either the dataset name or an actual value. The ionization potential should work the same and should have similar setter/getter logic to how the abundance property works.The text was updated successfully, but these errors were encountered: