Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New numpy release (v2.0.0) causing issues? #289

Closed
jwreep opened this issue Jun 19, 2024 · 1 comment · Fixed by #290
Closed

New numpy release (v2.0.0) causing issues? #289

jwreep opened this issue Jun 19, 2024 · 1 comment · Fixed by #290

Comments

@jwreep
Copy link
Collaborator

jwreep commented Jun 19, 2024

It seems like the newest release of Numpy (6/16/24) is causing issues with fiasco.

For example, this line

ds = hf.create_dataset('ion_index', data=np.array(ion_list).astype(np.string_))

uses np.string_ which has been removed in this release. This seems like it's causing the CI to fail (see the errors on #282 -- every single unit test is failing).

For the moment, perhaps pin the CI to an older version, but it seems like this might require a major overhaul to stamp out any issues.

@wtbarnes
Copy link
Owner

Thanks for bringing this up. I think the first step is to see whether the fixes that would accommodate v2.0 would also work with older versions.

To avoid problems like this in the future, we should probably also add an oldestdeps CI job as well as a devdeps one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants