-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydrogen- and helium-like atoms only for Z > 6 and 10? #251
Comments
That is a good question...I think I created these properties in order to use them in the ionization cross-section calculation here: Line 943 in 282b819
Line 975 in 282b819
ioniz_cross.pro routine: https://sohoftp.nascom.nasa.gov/solarsoft/packages/chianti/idl/ionrec/ioniz_cross.pro
The conditions on |
Perhaps it would be worth dropping this in the definitions, and putting the requirements on atomic number into the cross-section calculation directly? I could handle that, if so. |
Yes, that's definitely the right move. Thanks for spotting this. As a side note, I spoke with Peter Young about this issue of the range of Z for the cross-section calculation. He pointed out that in the Dere et al. 2007 (http://adsabs.harvard.edu/abs/2007A%26A...466..771D) paper, there's a note about the Fontes cross-sections being used for H-like ions of Carbon and above and using the FAC or BT scaling calculations for others. We should probably add a comment somewhere in that function that summarizes the justification in that paper. |
The definition of hydrogen-like requires
Z > 6
:return (self.atomic_number - self.charge_state == 1) and (self.atomic_number >= 6)
and helium-like
Z > 10
:return (self.atomic_number - self.charge_state == 2) and (self.atomic_number >= 10)
Why is this? Is He II not hydrogen-like? Or is there some logic or functionality that only applies to elements with higher atomic numbers?
The text was updated successfully, but these errors were encountered: