From 7934bbaca9e0983f83fc9430d509d30ca49dc3bb Mon Sep 17 00:00:00 2001 From: Adam Prescott Date: Thu, 22 Jun 2017 21:39:31 -0400 Subject: [PATCH] Re-splat arguments for the have_enqueued_job alias This makes sure that an extra level of array wrapping isn't added for tests which use the now-deprecated have_enqueued_job, which causes test failures. --- lib/rspec/sidekiq/matchers/have_enqueued_job.rb | 2 +- spec/rspec/sidekiq/matchers/have_enqueued_job_spec.rb | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/rspec/sidekiq/matchers/have_enqueued_job.rb b/lib/rspec/sidekiq/matchers/have_enqueued_job.rb index 28c7fa5..adcc2da 100644 --- a/lib/rspec/sidekiq/matchers/have_enqueued_job.rb +++ b/lib/rspec/sidekiq/matchers/have_enqueued_job.rb @@ -7,7 +7,7 @@ def have_enqueued_sidekiq_job(*expected_arguments) def have_enqueued_job(*expected_arguments) warn "[DEPRECATION] `have_enqueued_job` is deprecated. Please use `have_enqueued_sidekiq_job` instead." - have_enqueued_sidekiq_job(expected_arguments) + have_enqueued_sidekiq_job(*expected_arguments) end class JobOptionParser diff --git a/spec/rspec/sidekiq/matchers/have_enqueued_job_spec.rb b/spec/rspec/sidekiq/matchers/have_enqueued_job_spec.rb index 4e9874a..47b4f92 100644 --- a/spec/rspec/sidekiq/matchers/have_enqueued_job_spec.rb +++ b/spec/rspec/sidekiq/matchers/have_enqueued_job_spec.rb @@ -97,6 +97,10 @@ it 'provides deprecation warning' do expect { have_enqueued_job }.to output(/[DEPRECATION]/).to_stderr end + + it 'matches the same way have_enqueued_sidekiq_job does' do + expect(worker).to have_enqueued_job *worker_args + end end describe '#description' do