Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VR Mode #1

Merged
merged 2 commits into from
Dec 29, 2018
Merged

Fix VR Mode #1

merged 2 commits into from
Dec 29, 2018

Conversation

brianpeiris
Copy link
Contributor

@brianpeiris brianpeiris commented Dec 28, 2018

VR mode doesn't work unless you set renderer.vr.enabled = true. Unfortunately, this also breaks OrbitControls in non-VR mode, so I hacked in a fix for that as well.

@emilyselwood
Copy link
Owner

This doesn't seem to break anything in non vr mode and the changes look entirely reasonable so I am going to merge this.

This is not the canonical copy of this repo at the moment. It is over at https://github.com/wselwood/orbcalc I'll sort out the transfer of it over there so don't worry, but do you mind if I list you as a contributor over there?

I'm planning to pull out the server part so this becomes a sub module kept here, I'm not sure what will happen to the history of this repo when that happens, so your contribution may get lost. Sorry if that happens.

@emilyselwood emilyselwood merged commit 396e854 into emilyselwood:master Dec 29, 2018
emilyselwood added a commit to emilyselwood/orbcalc that referenced this pull request Dec 29, 2018
@brianpeiris
Copy link
Contributor Author

Sure, I'd be happy to be listed as a contributor. Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants