Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: phone credential type #87

Merged
merged 7 commits into from
Mar 7, 2023
Merged

feat: phone credential type #87

merged 7 commits into from
Mar 7, 2023

Conversation

paolodamico
Copy link
Contributor

  • Allows the host app to specify which credential types they're looking to verify. Example:
<IDKitWidget app_id="app_123" credential_types={[CredentialType.Phone, CredentialType.Orb]} />
  • By default, only CredentialType.Orb is accepted (if no credential types are configured).
  • Will issue a warning if invalid credential types are passed, and they will be ignored.

@vercel
Copy link

vercel bot commented Mar 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
idkit-js-example ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 7:41PM (UTC)

@paolodamico paolodamico requested a review from m1guelpf March 3, 2023 03:33
m1guelpf
m1guelpf approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@m1guelpf m1guelpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few code nits but feel free to ignore if this is blocking

@paolodamico paolodamico merged commit 9b42876 into main Mar 7, 2023
@paolodamico paolodamico deleted the phone-credential-pre branch March 7, 2023 19:45
@github-actions github-actions bot mentioned this pull request Mar 7, 2023
Merged
This was referenced Apr 22, 2023
Merged
Merged
@github-actions github-actions bot mentioned this pull request Jun 14, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 22, 2023
Closed
@github-actions github-actions bot mentioned this pull request Nov 23, 2023
Merged
This was referenced Feb 21, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1guelpf m1guelpf m1guelpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolodamico @m1guelpf