Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Text: Failed to insert media overlay has icon that is different colour from text #2429

Closed
enejb opened this issue Jun 25, 2020 · 3 comments
Assignees
Labels
good first issue Good for newcomers [Status] Needs Design [Type] Bug Something isn't working

Comments

@enejb
Copy link
Contributor

enejb commented Jun 25, 2020

Describe the bug
The current icon in the Failed to insert media overlay is light blue. Is that intended.

See:
Screen Shot 2020-06-25 at 10 36 25 AM

To Reproduce
Steps to reproduce the behavior:

  1. Insert media text block.
  2. Upload an image.
  3. Disconnect the phone from the internet. (Flight mode)
  4. See error

Expected behavior
I am expecting the icon to be the same colour as the text. (White)

Screenshots
Screen Shot 2020-06-25 at 10 36 25 AM

Smartphone (please complete the following information):

  • Device: iPhone 11
  • OS: iOS 13
  • Version 1.31
@enejb enejb added [Type] Bug Something isn't working good first issue Good for newcomers [Status] Needs Design labels Jun 25, 2020
@antonis
Copy link

antonis commented Jun 25, 2020

Hello @iamthomasbishop 👋
Should I leave the icon in the Failed to insert media overlay light blue or change it to the same colour as the text?

@enejb enejb mentioned this issue Jun 25, 2020
5 tasks
@enejb enejb changed the title Media Text: Failed to insert media overlay has Media Text: Failed to insert media overlay has icon that is different colour from text Jun 25, 2020
@antonis
Copy link

antonis commented Jun 30, 2020

This is already handled by WordPress/gutenberg#22788

@iamthomasbishop
Copy link
Contributor

Should I leave the icon in the Failed to insert media overlay light blue or change it to the same colour as the text?

@antonis I believe it can be changed to the same color as the text label.

@geriux geriux closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers [Status] Needs Design [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants