Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns Block: No limit to the number of columns that can be placed inside the column block #2425

Open
enejb opened this issue Jun 24, 2020 · 3 comments

Comments

@enejb
Copy link
Contributor

enejb commented Jun 24, 2020

Describe the bug
Currently in GB web you are limited to 6 columns that you can place in the column block.

On mobile there doesn't seem to be a limit.

My proposal is to limit the number of columns to a maximum of 6 columns this way we are in line with core.

See
Screen Shot 2020-06-25 at 4 39 29 PM

To Reproduce
Steps to reproduce the behavior:

  1. Add a column block.
  2. Keep adding columns. You can add more then 6 columns.

Expected behavior
We should limit the number of columns that you a user can create with the column block.

Smartphone (please complete the following information):

  • Device: iPhone 11
  • OS: iOS 13
  • Version 1.31
@enejb enejb added [Type] Bug Something isn't working Blocks InnerBlocks labels Jun 24, 2020
@enejb enejb mentioned this issue Jun 25, 2020
5 tasks
@enejb enejb changed the title No limit to the number of columns that can be placed inside the column block Columns Block: No limit to the number of columns that can be placed inside the column block Jun 25, 2020
@enejb enejb added Proposal and removed [Type] Bug Something isn't working labels Jun 25, 2020
@pinarol
Copy link
Contributor

pinarol commented Jun 25, 2020

There's not an actual limit on web as well. There was some time ago but they removed that limit. So if you select an individual column you'll be able to add columns more than 6:

Screen Shot 2020-06-25 at 18 06 07

Screen Shot 2020-06-25 at 18 12 26

As far as I see it displays a warning but let's you add more than 6. I think the web implementation still carries some old mechanisms but the behavior on mobile part is actually valid in this context and it was intentionally made this way.

@chipsnyder
Copy link
Contributor

As far as I see it displays a warning but let's you add more than 6.

Retested this today and it now appears that you can no longer add more than 6 unless you add them through the code editor.

@iamthomasbishop @kyleaparker any objections to limiting the number of columns to 6?

@iamthomasbishop
Copy link
Contributor

any objections to limiting the number of columns to 6?

@chipsnyder I wonder if we have any data on this, but I would be very surprised if there are many cases of 6+. In any case, if web is limiting to 6, I feel pretty comfortable doing the same on mobile. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants