Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On MacOS, when you remediate one or more files and enable debug logging, FileType.<TYPE> is output #237

Closed
davidnuzik opened this issue Feb 9, 2024 · 1 comment · Fixed by #238 or #240
Assignees
Labels
bug Something isn't working dev-complete Development work to resolve this issue is complete platform-specific A platform-specific issue or an inquiry about platform support qa-passed QA has tested and confirmed the fix for this issue
Milestone

Comments

@davidnuzik
Copy link

v3.0.2rc1
v3.0.1

Summary:
On MacOS, if you remediate one or more files, whether they are core, a theme, or a plugin, words like "core", "plugin", "theme" now read as "FileType." for example "FileType.CORE", "FileType.PLUGIN", "FileType.THEME".

This did not occur on Linux during my testing.

Steps to Reproduce:

  1. In a MacOS environment, remediate one or more known files. Core or theme or plugin. Ensure you enable debug logging.

Expected Result:
I expected to see the same output as on Linux when using the binary. ("plugin" or "theme" or "core")

Actual Result:
I see output like "FileType.PLUGIN" for example.

Additional Info:
Pre-existing issue. This was reproduced on v3.0.1 as well.

@davidnuzik davidnuzik added bug Something isn't working platform-specific A platform-specific issue or an inquiry about platform support labels Feb 9, 2024
@davidnuzik davidnuzik added this to the v3.0.2 milestone Feb 9, 2024
@akenion akenion self-assigned this Feb 9, 2024
@akenion akenion linked a pull request Feb 9, 2024 that will close this issue
@akenion akenion added dev-complete Development work to resolve this issue is complete qa-ready Issue is ready for QA and included in the most recent release candidate labels Feb 9, 2024
@davidnuzik
Copy link
Author

v3.0.2rc2

SUMMARY:
QA validation PASSED.
I no longer see automation tests failing and when I manually test restoration of any core, plugin, or theme file(s) they now read as normal (like "plugin", "theme", "core" without the "FileType" and all caps).

VALIDATION STEPS

  1. Execute automation on MacOS. All passes. Check Linux as well. All passes.
  2. Manually remediate 1 or more files of each type: core, plugin, and theme. I chose random ones. This works as expected now both on Mac and Linux without any issues.

NOTES:
Note, Linux was working prior but both were checked to ensure nothing else broke.

@davidnuzik davidnuzik added qa-passed QA has tested and confirmed the fix for this issue and removed qa-ready Issue is ready for QA and included in the most recent release candidate labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev-complete Development work to resolve this issue is complete platform-specific A platform-specific issue or an inquiry about platform support qa-passed QA has tested and confirmed the fix for this issue
Projects
None yet
2 participants