Allow Enable/Disable Scrolling #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 24, 2019 17:06
lojals
added
bug
Abel7x
approved these changes
Aug 1, 2019
leonardo-garcia
suggested changes
Aug 1, 2019
WLEmptyState/Classes/Extensions/UICollectionView+WLEmptyState.swift
Outdated
Show resolved
Hide resolved
squallone
reviewed
Aug 1, 2019
WLEmptyState/Classes/Extensions/UICollectionView+WLEmptyState.swift
Outdated
Show resolved
Hide resolved
leonardo-garcia
approved these changes
Aug 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Any background context you want to provide?
Sometimes users want to disable scrolling on the Empty States. Some other times they want to enable to activate pull to refresh and so on.
This PR provides a new way to handle that setting.
Where should the reviewer start?
WLEmptyState/Classes/Protocols/WLEmptyStateDelegate.swiftHow should this be manually tested?
Questions
N/A