Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aside styling of code, blockquote, and hr could be improved #2118

Closed
1 task done
evadecker opened this issue Jul 10, 2024 · 0 comments · Fixed by #2119
Closed
1 task done

Aside styling of code, blockquote, and hr could be improved #2118

evadecker opened this issue Jul 10, 2024 · 0 comments · Fixed by #2119

Comments

@evadecker
Copy link
Contributor

evadecker commented Jul 10, 2024

What version of starlight are you using?

0.25.0

What version of astro are you using?

4.10.2

What package manager are you using?

pnpm

What operating system are you using?

Mac

What browser are you using?

Chrome

Describe the Bug

The styling of tables within Aside was recently improved, but there are additional inline components which do not look great inside an Aside.

The border of the hr and the blockquote are difficult to see on certain colors, and the background of code causes a vibrating effect when used on certain backgrounds. All colors could be improved by using the same approach as the new dividers of the table, by taking a tinted shade and applying it to the element instead of using a static gray color.

CleanShot 2024-07-10 at 00 04 16@2x

CleanShot 2024-07-10 at 00 05 25@2x

CleanShot 2024-07-10 at 00 05 37@2x

CleanShot 2024-07-10 at 00 05 47@2x

CleanShot 2024-07-10 at 00 06 04@2x

CleanShot 2024-07-10 at 00 06 26@2x

CleanShot 2024-07-10 at 00 06 42@2x

CleanShot 2024-07-10 at 00 06 54@2x

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-scoyw2?file=src%2Fcontent%2Fdocs%2Findex.mdx

Participation

  • I am willing to submit a pull request for this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant