Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better healthchecks #28

Closed
oleg-nenashev opened this issue Apr 27, 2023 · 6 comments
Closed

Provide better healthchecks #28

oleg-nenashev opened this issue Apr 27, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request testcontainers

Comments

@oleg-nenashev
Copy link
Member

Proposal

Follow-up to #25. Once wiremock/wiremock#2164 is implemented in WireMock Core and added to the WireMock Docker, it would be nice to adapt the code to use better healthcheck endpoint for newer versions of the container image

References

No response

@oleg-nenashev oleg-nenashev added the enhancement New feature or request label Apr 27, 2023
@oleg-nenashev
Copy link
Member Author

While wiremock/wiremock#2164 is not implemented , as noted by @wallid , we need another health check that would at least verify that the instance can serve some mock endpoints. It will be also useful for any 2.x tests

I suggest the following:

  1. If any withMapping() method is passed, note that the mappings should be present
  2. If so, also verify the response of /__admin/mappings and ensure that the response is not null

@oleg-nenashev
Copy link
Member Author

Now we can do better healtchecks starting from WireMock 3.0

@kapishmalik
Copy link
Contributor

@oleg-nenashev I can take this up

@oleg-nenashev
Copy link
Member Author

Go for it

@kapishmalik
Copy link
Contributor

started working on the same. I will raise PR in sometime.

@kapishmalik
Copy link
Contributor

@oleg-nenashev created PR for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testcontainers
Projects
None yet
Development

No branches or pull requests

2 participants