Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MySQL remove_index #264

Merged
merged 1 commit into from
Nov 25, 2018
Merged

Fix MySQL remove_index #264

merged 1 commit into from
Nov 25, 2018

Conversation

tetz-akaneya
Copy link
Contributor

@tetz-akaneya tetz-akaneya commented Nov 25, 2018 •
edited
Loading

Fixed bug about MySQL adapter for mysql-use-alter option.

  1. Rename remove_index! to remove_index because remove_index! hasn't been called.
  2. Use index_name_for_remove to get index_name, just like ActiveRecord.

Related line:
https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb#L795

@winebarrel
Copy link
Member

Thank you! 👍

@winebarrel winebarrel merged commit ca01097 into ridgepole:0.7 Nov 25, 2018
@winebarrel
Copy link
Member

v0.7.5.beta2 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tetz-akaneya @winebarrel