Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use absolute imports for vx components, update builds to support absolute imports for data-ui components #49

Closed
williaster opened this issue Aug 16, 2017 · 1 comment

Comments

@williaster
Copy link
Owner

currently we import components from vx via import { MyComponent } from '@vx/package' which means bundles will include the entire vx package we are importing from. this could be improved with absolute imports import MyComponent from @vx/package/build/....

similarly we only build an index for each @data-ui package which means users get the entire package when they import a single component. this could be improved by exporting the entire build directory to support absolute imports for @data-ui components.

@williaster williaster changed the title use absolute imports for vx components, update builds to support absolute imports fro data-ui components use absolute imports for vx components, update builds to support absolute imports for data-ui components Aug 16, 2017
@williaster
Copy link
Owner Author

closed with tree shaking and per-file builds in #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant