house_number is required for some countries but the plugin is sending addressLine2 (which is sometimes empty and not usually a house number)

[bleepsandblops]

Description

This line is sending the addressLine2 field instead of the Sendcloud 'house_number'
https://github.com/white-nl/commerce-sendcloud/blob/71754d24f57162d732c0c1ab30af05bebc4f3247/src/client/JouwWebSendcloudAdapter.php#L245C32-L245C32

Problem is on some countries (Switzerland is where I got the bug but there may be more), that field is required. So if the line 2 is empty, we're getting this back from sendcloud:

And actually, there is a field for addressLine2 which currently is sending as blank:

commerce-sendcloud/src/client/JouwWebSendcloudAdapter.php

Line 251 in 71754d2

'',

A solution could be to extract the house number from the address Craft-side, and use that instead, + send address line 2 where it should be. Only thing is I feel like the extraction logic could potentially be quite tricky...

Steps to reproduce

Additional info

• Craft version: 4.4.14
• PHP version: 2.2.1
• Database driver & version:
• Plugins & versions: Commerce 4.2.11

[bleepsandblops]

New problem with sending addressLine2 as house_number:
house_number: "Ensure this field has no more than 20 characters."

[WHITE-developer]

Hi @bleepsandblops,
Thanks for reporting, we're going to look how we can best change this, to minimize braking changes.
Probably in combination with Webador/sendcloud#23

[WHITE-developer]

3.0.0 is now released with the fix. Thank you for your patience.