Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock network requests instead of actually sending network requests #291

Open
Freso opened this issue Aug 21, 2018 · 0 comments
Open

Mock network requests instead of actually sending network requests #291

Freso opened this issue Aug 21, 2018 · 0 comments
Labels
Accepted Accepted issue on our roadmap Feature New feature Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) Needed: patch A pull request is required
Milestone
2.0

Comments

@Freso
Copy link
Member

Freso commented Aug 21, 2018

Currently there are several tests that are dependent on both the client being online, but also on the service (MusicBrainz, AccurateRip, …) being accessible. This is a rather fault prone setup that both makes tests susceptible to random failures and can also cause some issues downstream for packages, where packages may need to be built and tested without networking access (e.g., Gentoo).
@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Feature New feature Needed: patch A pull request is required Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) and removed enhancement labels Nov 12, 2018
@JoeLametta JoeLametta added this to the 2.0 milestone Nov 13, 2018
@JoeLametta JoeLametta mentioned this issue Nov 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Feature New feature Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) Needed: patch A pull request is required
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@Freso @JoeLametta