-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out why morituri compares the cdrdao fast-toc against the slow-toc #173
Comments
Glad you made this, I had wondered about this myself before and did some preliminary investigation before, but was focused on answering the pre-emphasis flag origins question and never finished. First step is to investigate what cdrdao does differently when the |
Done? |
I don't think so. It still doesn't make sense to me. |
This may have been some kind of paranoid mode, which unfortunately breaks whipper with some drives and costs a lot of time. AccurateRip should be good enough to verify the correctness. Whipper's Musicbrainz lookup already happens to use the result of |
Now that getFastToc() isn't faster than getTable() anymore (since #345 I think), it seems obvious that getFastToc() was previously meant to speed up two things:
|
I don't think 1. and 2. were the main reason for getFastToc. Or rather, let me rephrase: why do we not always use fast-toc? The manual says this:
I've done some tests and I found that the results are often the same. So maybe most CDs have 2s pregaps already. I've done about 200,000 rips with just |
As title: Figure out why morituri compares the cdrdao fast-toc against the slow-toc, and understand if/why we need the slow toc.
The text was updated successfully, but these errors were encountered: