Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why morituri compares the cdrdao fast-toc against the slow-toc #173

Open
MerlijnWajer opened this issue Jun 14, 2017 · 6 comments
Labels
Support Questions that needs answering with no code changes needed or that only require a one time change
Milestone

Comments

@MerlijnWajer
Copy link
Collaborator

As title: Figure out why morituri compares the cdrdao fast-toc against the slow-toc, and understand if/why we need the slow toc.

@RecursiveForest RecursiveForest self-assigned this Aug 12, 2017
@RecursiveForest
Copy link
Contributor

Glad you made this, I had wondered about this myself before and did some preliminary investigation before, but was focused on answering the pre-emphasis flag origins question and never finished. First step is to investigate what cdrdao does differently when the --fast-toc flag is applied to read-toc.

@JoeLametta
Copy link
Collaborator

Done?

@JoeLametta JoeLametta added the Support Questions that needs answering with no code changes needed or that only require a one time change label Mar 8, 2018
@MerlijnWajer
Copy link
Collaborator Author

I don't think so. It still doesn't make sense to me.

@JoeLametta JoeLametta added this to the 2.0 milestone Apr 6, 2018
@mtdcr
Copy link
Contributor

mtdcr commented Apr 21, 2018

This may have been some kind of paranoid mode, which unfortunately breaks whipper with some drives and costs a lot of time. AccurateRip should be good enough to verify the correctness. Whipper's Musicbrainz lookup already happens to use the result of cdrdao read-toc --fast-toc.

@mtdcr
Copy link
Contributor

mtdcr commented Sep 21, 2019

Now that getFastToc() isn't faster than getTable() anymore (since #345 I think), it seems obvious that getFastToc() was previously meant to speed up two things:

  1. Getting to the point where MusicBrainz can get queried.
  2. Using the table cache to avoid having to obtain the regular TOC more than once.

@MerlijnWajer
Copy link
Collaborator Author

I don't think 1. and 2. were the main reason for getFastToc. Or rather, let me rephrase: why do we not always use fast-toc?

The manual says this:

       --fast-toc
              Only used for command read-toc.  This option suppresses the pre-gap length and index mark extraction which speeds up the  read-toc
              process.  Standard  2  second  pre-gaps  (but  no silence!) will be placed into the toc-file. The resulting CD will sound like the
              source CD. Only the CD player's display will behave slightly different in the transition area between two tracks.

              This option might help, too, if read-toc fails with your drive otherwise.

I've done some tests and I found that the results are often the same. So maybe most CDs have 2s pregaps already. I've done about 200,000 rips with just --fast-toc and never using the slow toc -- because it takes way too long. That's what this issue was about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support Questions that needs answering with no code changes needed or that only require a one time change
Projects
None yet
Development

No branches or pull requests

4 participants