Update customized built-in elements is="" interaction #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the DOM changes in whatwg/dom#566, and is part of fixing #3402. The normative changes are to the serialization algorithm, which now writes out the element's is value as its is="" attribute, if no actual is="" attribute is present. The rest of the changes are to introductory text about customized built-in elements.
domenic
added
topic: custom elements
annevk
reviewed
Feb 3, 2018
source
Outdated
| data-x="">is="</code>", followed by <var>current node</var>'s <span | ||
| data-x="concept-element-is-value"><code data-x="">is</code> value</span> <span | ||
| data-x="escaping a string">escaped as described below</span> in <i>attribute mode</i>, | ||
| followed by a U+0022 QUOTATION MARK character (").</p> |
There was a problem hiding this comment.
You need to start with U+0020 SPACE.
source
Outdated
| </script></pre> | ||
| </div> | ||
|
|
||
| <p><dfn id="escapingString">Escaping a string</dfn> (for the purposes of the algorithm above) |
source
Outdated
| through serialize-parse roundtrips.</p> | ||
|
|
||
| <div class="example"> | ||
| <p>When creating a <span>customized built-in element</span> via the parser, a developer uses the <code |
tkent-google
approved these changes
Feb 14, 2018
source
Outdated
| @@ -65645,20 +65645,29 @@ document.body.appendChild(flagIcon)</pre> | |||
| me?</plastic-button></code> will simply create an <code>HTMLElement</code> with no special | |||
| behavior.</p> | |||
|
|
|||
| <p>If you need to create a type-extended element programmatically, you can use the following form | |||
| of <code data-x="dom-Document-createElement">createElement()</code>:</p> | |||
| <p>If you need to create a customized built-in element element programmatically, you can use the | |||
There was a problem hiding this comment.
element element → element
domenic
added a commit
to whatwg/dom
that referenced
this pull request
Feb 14, 2018
Part of fixing whatwg/html#3402. This changes two things: * It fixes the cloning steps to consult the internal is value, instead of the is="" content attribute. * It removes the step from createElement()/createElementNS() that would insert an is="" attribute in the created element, as we've now decided that is="" is a way of communicating to the parser, and not a general-purpose indicator of customized built-in-ness. See also whatwg/html#3444 for the other half of the fix. Tests: web-platform-tests/wpt#9505
tkent-google
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 14, 2018
tkent-google
approved these changes
Feb 14, 2018
|
WPT PR for this PR: web-platform-tests/wpt#9508 |
domenic
removed
the
needs tests
sideshowbarker
approved these changes
Feb 14, 2018
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 14, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 1, 2018
…tests, a=testonly Automatic update from web-platform-tests[custom-elements] Add HTML serialization tests This is for whatwg/html#3444 wpt-commits: d0114efdde520f9aa003ce42c85ef134f01ad691 wpt-pr: 9508 wpt-commits: d0114efdde520f9aa003ce42c85ef134f01ad691 wpt-pr: 9508
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
…tests, a=testonly Automatic update from web-platform-tests[custom-elements] Add HTML serialization tests This is for whatwg/html#3444 wpt-commits: d0114efdde520f9aa003ce42c85ef134f01ad691 wpt-pr: 9508 wpt-commits: d0114efdde520f9aa003ce42c85ef134f01ad691 wpt-pr: 9508 UltraBlame original commit: bbea3b6d26ec8ffb62e798a31c019e10454115e0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
…tests, a=testonly Automatic update from web-platform-tests[custom-elements] Add HTML serialization tests This is for whatwg/html#3444 wpt-commits: d0114efdde520f9aa003ce42c85ef134f01ad691 wpt-pr: 9508 wpt-commits: d0114efdde520f9aa003ce42c85ef134f01ad691 wpt-pr: 9508 UltraBlame original commit: bbea3b6d26ec8ffb62e798a31c019e10454115e0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
…tests, a=testonly Automatic update from web-platform-tests[custom-elements] Add HTML serialization tests This is for whatwg/html#3444 wpt-commits: d0114efdde520f9aa003ce42c85ef134f01ad691 wpt-pr: 9508 wpt-commits: d0114efdde520f9aa003ce42c85ef134f01ad691 wpt-pr: 9508 UltraBlame original commit: bbea3b6d26ec8ffb62e798a31c019e10454115e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the DOM changes in whatwg/dom#566,
and is part of fixing #3402.
The normative changes are to the serialization algorithm, which now
writes out the element's is value as its is="" attribute, if no actual
is="" attribute is present. The rest of the changes are to introductory
text about customized built-in elements.
Tests for this will presumably be done at the same time as those for the DOM changes.
/custom-elements.html ( diff )
/parsing.html ( diff )