Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorprofile destination #1331

Closed
wants to merge 3 commits into from
Closed

Add colorprofile destination #1331

wants to merge 3 commits into from

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Oct 12, 2021

For CSS color-profiles
(https://drafts.csswg.org/css-color-4/#at-profile)

Uses style-src for CSP.

Closes #1324

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chrome: …
    • Firefox: …
    • Safari: …

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo nit this looks good. Though as a follow-up the order of destinations in the table needs adjusting. It used to be lexicographical within a given initiator, but that got lost after some additions.

@annevk
Copy link
Member

annevk commented Oct 12, 2021

So I checked and as far as implementer interest this is kinda hard to assess as there are many other color features to tackle first. I guess we could add this mainly for registry purposes and consider it close to editorial.

@domenic @foolip thoughts?

@domenic
Copy link
Member

domenic commented Oct 12, 2021

Eh, I mean, it seems like you should be able to answer "are multiple implementations planning on fetching color profiles, or is fetching color profiles a single-browser idea/a CSSWG spec-fiction?"

I think we can relax the

The support from implementers should be of the form “we would like to implement this soon” and not just “this seems like a reasonable idea”.

request in this case since it's more of a registry/cross-spec integration issue. But it'd still be good to double-check that we're not putting something in that will never get implemented, or that supports a forever-single-vendor feature.

@annevk
Copy link
Member

annevk commented Oct 13, 2021

Fair. For Gecko it's something we'd probably consider implementing once we have all the other wide gamut features, but there isn't even a concrete half-float canvas API proposal yet, so it really seems quite far out there. And then I'm not sure to what extent the external color profile formats have been vetted. It certainly seems like the fetch pipeline has seen little attention. Do you know who to ask for Chromium? @smfr I guess color profiles are something you can comment on for WebKit?

@smfr
Copy link

smfr commented Oct 13, 2021

I think I've stated in the past that Apple doesn't have any plans to implement color profile fetching. There are too many issues with asynchrony to work out.

@noamr
Copy link
Contributor Author

noamr commented Jan 17, 2022

Closing for now as color profiles are far from consensus at this point.

@noamr noamr closed this Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Missing destination types for some style initiated resources
4 participants