Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutting down txoutbox leaves dangling go routines #55

Closed
rhinof opened this issue May 1, 2019 · 1 comment
Closed

Shutting down txoutbox leaves dangling go routines #55

rhinof opened this issue May 1, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@rhinof
Copy link
Contributor

rhinof commented May 1, 2019

When shutting down the txoutbox we do not properly close the exit channel leaving dangling goroutines which litter the logs when shutting down the bus
@rhinof rhinof added the bug Something isn't working label May 1, 2019
This was referenced May 1, 2019
Closed
Merged
@rhinof rhinof closed this as completed May 1, 2019
@rhinof
Copy link
Contributor Author

rhinof commented May 1, 2019

fixed #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shutdown fix wework/grabbit
1 participant
@rhinof